Contributing to Genode, questions before upstreaming

[fdelizy]

Hi,

I am reviewing the following document:

Genode - Contributing to Genode

One of the key-points is:

create a new topic branch based on the genodelabs/master branch. For example,

 git checkout -b issue76

2 questions:

• should we target master? or staging instead? I see some evolutions between these branches (as expected) and I am wondering what would be making the merge process easier for the maintainers?
• the format for branch naming (implied) is the number of the issue, since in my case I am likely going to have multiple of those, would it be ok if I add a more human-readable description, something like fix/issueXX-what_this_topic_is_about ? this would help me keep track more easily.

side note:

• I have signed the GCA, (and so did Karin, working with me), we attached this onto NYCU email but some of our accounts of github/codeberg may leak our @gmail address instead, will that be ok? (I’ll add a Authored-by trailer in hope you can match them, and will try to be cautious about it though).

Also, would you suggest me to create a first topic on this discouse forum first, before starting an issue on github or codeberg to discuss? or go straight for the issue and keep the convo there?

I am hoping asking questions about the process is ok based on the last piece:

Please do not take the steps described herein too seriously. They are not carved in stone. If you have suggestions for improving them, or if you feel staggered by all those rules, please let us know.

Let me know your thoughts

[chelmuth]

@fdelizy

• should we target master? or staging instead? I see some evolutions between these branches (as expected) and I am wondering what would be making the merge process easier for the maintainers?

Developments should target the main branch. We will ask for a rebase to staging if required during the review process.

@fdelizy

• the format for branch naming (implied) is the number of the issue, since in my case I am likely going to have multiple of those, would it be ok if I add a more human-readable description, something like fix/issueXX-what_this_topic_is_about ? this would help me keep track more easily.

Feel free to name your branches according to your gusto.

@fdelizy

Also, would you suggest me to create a first topic on this discouse forum first, before starting an issue on github or codeberg to discuss? or go straight for the issue and keep the convo there?

As this is the Genode Users it exists mainly for discussing user related matters. Almost all technical discussions with strong relations to the implementation happen in the issue tracker (now on Codeberg).

[fdelizy]

@chelmuth

As this is the Genode Users it exists mainly for discussing user related matters. Almost all technical discussions with strong relations to the implementation happen in the issue tracker (now on Codeberg).

Oh… my bad, I thought that was the point of the “Developer’s Corner” ^^;

alright then, let me rebase my work on master and start the upstreaming process, small things first, bigger next